I\u2019m currently watching an cool video of PoshBoard<\/A> a PowerShell based Web Portal by Pilosite available on CodePlex<\/A>. It looks great. <\/P>\n In the middle of the video I noticed the following script he uses to populate one of the controls on the dashboard:<\/P>\n $ht = @{ } This is perfectly fine code but I noticed a couple opportunities for improvement:<\/P>\n Those observations allow us to transform<\/P>\n $objDrives = gwmi \u2013class \u201cWin32_logicalDisk\u201d \u2013Namespace \u201croot\\cimv2\u201d |where {$_.DriveType -eq 3 }<\/FONT><\/P>\n into<\/P>\n $objDrives = gwmi Win32_logicalDisk \u2013Filter \u201cDriveType = 3\u201d<\/FONT> Next I noticed that it was using a foreach loop to create a hashtable. I\u2019ve seen lots of code like this and in talking to a lot of new users, I\u2019ve come the the conclusion that there are a set of beginner users that have a difficult time getting their heads around control structures (e.g. if\/elseif\/else, for, foreach, while, do\/until). These folks seem to do just fine with commands and pipelines so I\u2019m on the lookout for ways to make control structures option. In the spirit, I wrote ConvertTo-HashTable.ps1 :<\/P>\n # ConvertTo-hashTable.ps1 $value Once you have this (and you notice that you can get rid of the multiplying and dividing by 1024), we can transform this:<\/P>\n $ht = @{ } into this:<\/P>\n $ht = gwmi Win32_logicalDisk \u2013Filter \u201cDriveType = 3\u201d | ConvertTo-HashTable DeviceId {$_.size – $_.freeSpace}<\/FONT><\/P>\n That looks pretty readable to me.<\/P>\n BTW – here is the video <\/P>\n
$objDrives = gwmi \u2013class \u201cWin32_logicalDisk\u201d \u2013Namespace \u201croot\\cimv2\u201d |where {$_.DriveType -eq 3 }
foreach ($ObjDisk in $objDrives)
{
$size = $objDisk.size \/ 1024
$freespace = $objDisk.FreeSpace \/ 1024
$IntUsed = ($size – $freeSpace) * 1024
$ht.Add($objDisk.DeviceId, $IntUsed)
}<\/FONT><\/P>\n\n
<\/P>\n
#
param(
[string]
$key, <\/FONT><\/P>\n
)
Begin
{
$hash = @{}
$Script = $false
if ($value -is [ScriptBlock])
{
$Script = $true
}
}
Process
{
$thisKey = $_.$Key
if ($script)
{
$hash.$thisKey = & $Value
}else
{
$hash.$thisKey = $_.$Value
}
}
End
{
Write-Output $hash
}<\/FONT><\/P>\n
$objDrives = gwmi \u2013class \u201cWin32_logicalDisk\u201d \u2013Namespace \u201croot\\cimv2\u201d |where {$_.DriveType -eq 3 }
foreach ($ObjDisk in $objDrives)
{
$size = $objDisk.size \/ 1024
$freespace = $objDisk.FreeSpace \/ 1024
$IntUsed = ($size – $freeSpace) * 1024
$ht.Add($objDisk.DeviceId, $IntUsed)
}<\/FONT><\/P>\n