\nA customer was having trouble with their\n \nGiven what you know about shell context menus,\nyou can already direct the investigation.\nI’ll let you\n\nread up about it first<\/A>,\n\nespecially the part about composition<\/A>,\nthen we can see how much you’ve learned.\n<\/P>\n \nWelcome back.\n(Okay, I know you didn’t actually do the reading,\nbut I’m welcoming you back anyway.)\n<\/P>\n \nYour first theory as to why\n \n“Nope, that’s not it.\nWe’re returning\n \nOh great, the customer is now playing Twenty Questions.\n<\/P>\n \n“I’m going to pose a puzzle with almost no clues,\nand you get to propose solutions,\nand I’ll say whether or not you’re right.”\n<\/P>\n \nI don’t know why customers play this game.\nMaybe they don’t realize that asking for help via email\nis very different from asking for help face-to-face.\nIn a face-to-face conversation,\nthe answer to a question arrives within seconds,\nwhereas in email it can take hours or days.\nThis means that when the answer finally comes back,\nthe person asking the question has\nto go back and read the conversation history\nthread to re-establish context.\n<\/P>\n \nOr maybe they think they’re going to be disclosing\nTop Secret Information to Microsoft if they\nshare the code that they can’t get to work.\nTrust me, we don’t care about your Top Secret Algorithm\nfor Beating the Stock Market With No Money Down.\nGo ahead and remove those from the code.\nWe just want to see how you are interfacing with the shell.\n(And besides, you probably should be removing them anyway,\nsince they are irrelevant and are not part\nof a minimal program that reproduces the problem.)\n<\/P>\n \nWhat would your next guess be?\n<\/P>\n \n“Perhaps you’re adding your items with the wrong menu item ID.”\nThat would explain the problem,\nbecause returning\n \n“Your intuition is wrong again.\nHere’s the code we’re using.”\n<\/P>\n \nI can abide by the “Ha ha, you guessed wrong again!”\nbecause it at least prodded them into sharing some code.\nNot much code, mind you, but at least some.\n<\/P>\n \nThe next thing you should have noticed is that they\nnever actually used the\n \n“Could you tell us more about the\n \nbut perhaps there’s something going on that we are missing.”\n<\/P>\n \nThe customer cheerfully replied,\n“Oops, sorry, didn’t notice that.\nWorks great now, thanks!”\n<\/P>\n \nI didn’t bother to draw their attention to the fact that they\nlied when they responded to the question\n“Did you add the menu item with the correct ID?”\nwith “Wrong again! BZZZT!”\n<\/P>\n \nThe point of today’s story is that you, gentle reader,\nalready know how to debug these types of issues.\nYou just have to take what you know and apply it to the situation\nat hand.\nIf you know how composite context menu dispatch works,\nthen you can come up with failure modes in which the dispatcher\nfails to match up the menu item with the component.\n<\/P>\n \nExercise<\/B>:\nThe customer is still not out of the woods yet.\nWhat other bug remains in their\n A customer was having trouble with their IContextMenu implementation. They observed that their IContextMenu::QueryContextMenu method was being called, but when the user selected their menu item, IContextMenu::InvokeCommand was not being called. Given what you know about shell context menus, you can already direct the investigation. I’ll let you read up about it first, especially the […]<\/p>\n","protected":false},"author":1069,"featured_media":111744,"comment_status":"open","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"_acf_changed":false,"footnotes":""},"categories":[1],"tags":[25],"class_list":["post-5383","post","type-post","status-publish","format-standard","has-post-thumbnail","hentry","category-oldnewthing","tag-code"],"acf":[],"blog_post_summary":" A customer was having trouble with their IContextMenu implementation. They observed that their IContextMenu::QueryContextMenu method was being called, but when the user selected their menu item, IContextMenu::InvokeCommand was not being called. Given what you know about shell context menus, you can already direct the investigation. I’ll let you read up about it first, especially the […]<\/p>\n","_links":{"self":[{"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/posts\/5383","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/users\/1069"}],"replies":[{"embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/comments?post=5383"}],"version-history":[{"count":0,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/posts\/5383\/revisions"}],"wp:featuredmedia":[{"embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/media\/111744"}],"wp:attachment":[{"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/media?parent=5383"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/categories?post=5383"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/tags?post=5383"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}IContextMenu<\/CODE> implementation.\nThey observed that their\nIContextMenu::QueryContextMenu<\/CODE> method\nwas being called,\nbut when the user selected their menu item,\nIContextMenu::InvokeCommand<\/CODE> was\nnot being called.\n<\/P>\nIContextMenu::InvokeCommand<\/CODE> is\nnot being called is probably\nthat they returned S_OK<\/CODE> from\nIContextMenu::QueryContextMenu<\/CODE> instead\nof\nMAKE_HRESULT(SEVERITY_SUCCESS,\nFACILITY_NULL, 1)<\/CODE>.\nThat would explain the problem, because a return value of\nS_OK<\/CODE>\nis equivalent to\nMAKE_HRESULT(SEVERITY_SUCCESS,\nFACILITY_NULL, 0)<\/CODE>,\nwhich means\n“I successfully added up to zero menu items starting at\nidCmdFirst<\/CODE>.”\nWhen the user picks the menu item they added,\nthe dispatcher will go looking for the corresponding\ncomposite menu component,\nand since they said that they used zero entries,\nthey will naturally never be called,\nsince they disavowed any responsibility for those items.\n<\/P>\nMAKE_HRESULT(SEVERITY_SUCCESS,\nFACILITY_NULL, 1)<\/CODE>.\nAny other guesses?”\n<\/P>\nMAKE_HRESULT(SEVERITY_SUCCESS,\nFACILITY_NULL, 1)<\/CODE>\nmeans\n“I successfully added up to one menu item starting at\nidCmdFirst<\/CODE>.”\nBut if they didn’t actually add it at idCmdFirst<\/CODE>,\nthen when the user selects the item,\nit won’t be in the range they claimed,\nand therefore the invoke won’t get routed to them.\n<\/P>\n\nHRESULT SooperSeekrit::QueryContextMenu(\n HMENU hmenu,\n UINT indexMenu,\n UINT idCmdFirst,\n UINT idCmdLast,\n UINT uFlags)\n{\n UINT cItemsAdded = 0;\n if (!(uFlags & CMF_DEFAULTONLY) &&\n InsertMenuItem(hmenu,\n indexMenu,\n TRUE,\n &globalMenuItemInfo)) {\n return MAKE_HRESULT(SEVERITY_SUCCESS, FACILITY_NULL, 1);\n }\n return MAKE_HRESULT(SEVERITY_SUCCESS, FACILITY_NULL, 0);\n}\n<\/PRE>\nidCmdFirst<\/CODE> parameter.\nSo how could they claim to be adding the items with the correct\nmenu item ID if they ignore the variable that tells them what\nthe correct menu item ID is?\n<\/P>\nglobalMenuItemInfo<\/CODE>\nvariable?\nIn particular, what value does it use for the wID<\/CODE> member,\nand how do you make sure that it is equal to\nidCmdFirst<\/CODE>?\nIt seems that you are missing some lines of code here:\n<\/P>\n\nglobalMenuItemInfo.fMask |= MIIM_ID;\nglobalMenuItemInfo.wID = idCmdFirst;\n<\/PRE>\n
IContextMenu::QueryContextMenu<\/CODE>\nimplementation?\n<\/P><\/p>\n","protected":false},"excerpt":{"rendered":"