If you try to do too much, you can find yourself in trouble.<\/p>\n
For example, if your destructor hands a reference to itself to other functions, those functions might decide to call your That doesn’t look so scary now does it? The object saves itself when destructed.<\/p>\n However, the On its own, this looks pretty normal. Get a stream and save to it, setting ourselves as its site in case the stream wants to get additional information about the object as part of the saving process.<\/p>\n But in conjunction with the fact that we call it from our destructor, we have a recipe for disaster. Watch what happens when the last reference is released.<\/p>\n Destructing the object a second time tends to result in widespread mayhem. If you’re lucky, you’ll crash inside the recursive destruction and identify the source, but if you’re not lucky, the resulting heap corruption won’t go detected for quite some time, at which point you’ll just be left scratching your head.<\/p>\n Therefore, at a minimum, you should assert in your This would catch the “case of the mysteriously double-destructed object” much earlier in the game, giving you a fighting chance of identifying the problem. But once you’ve isolated the problem, what can you do about it? We’ll look into that next time<\/a>.<\/p>\n","protected":false},"excerpt":{"rendered":" If you try to do too much, you can find yourself in trouble.<\/p>\n","protected":false},"author":1069,"featured_media":111744,"comment_status":"open","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"_acf_changed":false,"footnotes":""},"categories":[1],"tags":[25],"class_list":["post-34023","post","type-post","status-publish","format-standard","has-post-thumbnail","hentry","category-oldnewthing","tag-code"],"acf":[],"blog_post_summary":" If you try to do too much, you can find yourself in trouble.<\/p>\n","_links":{"self":[{"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/posts\/34023","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/users\/1069"}],"replies":[{"embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/comments?post=34023"}],"version-history":[{"count":0,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/posts\/34023\/revisions"}],"wp:featuredmedia":[{"embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/media\/111744"}],"wp:attachment":[{"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/media?parent=34023"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/categories?post=34023"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/tags?post=34023"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}IUnknown::AddRef<\/code> and IUnknown::Release<\/code> methods as part of their internal operations. Consider:<\/p>\nULONG MyObject::Release()\r\n{\r\n LONG cRef = InterlockedDecrement(&m_cRef);\r\n if (cRef == 0) {\r\n delete this;\r\n }\r\n return cRef;\r\n}\r\n\r\nMyObject::~MyObject()\r\n{\r\n if (m_fNeedSave) Save();\r\n}\r\n<\/pre>\nSave<\/code> method might do something like this:<\/p>\nHRESULT MyObject::Save()\r\n{\r\n CComPtr<IStream> spstm;\r\n HRESULT hr = GetSaveStream(&spstm);\r\n if (SUCCEEDED(hr)) {\r\n CComQIPtr<IObjectWithSite, &IID_IObjectWithSite> spows(spstm);\r\n if (spows) spows->SetSite(this);\r\n hr = SaveToStream(spstm);\r\n if (spows) spows->SetSite(NULL);\r\n }\r\n return hr;\r\n}\r\n<\/pre>\n\n
Release()<\/code> method decrements the reference count to zero and performs a delete this<\/code>.<\/li>\nSave()<\/code> method obtains the save stream and sets itself as the site. This increments the reference count from zero to one.<\/li>\nSaveToStream()<\/code> method saves the object.<\/li>\nSave()<\/code> method clears the site on the stream. This decrements the reference count from one back to zero.<\/li>\nRelease()<\/code> method therefore attempts to destructor the object a second time.<\/li>\n<\/ul>\nAddRef()<\/code> method that you aren’t incrementing the reference count from zero.<\/p>\nULONG MyObject::AddRef()\r\n{\r\n assert(m_cRef != 0);<\/span>\r\n return InterlockedIncrement(&m_cRef);\r\n}\r\n<\/pre>\n