{"id":109967,"date":"2024-07-12T07:00:00","date_gmt":"2024-07-12T14:00:00","guid":{"rendered":"https:\/\/devblogs.microsoft.com\/oldnewthing\/?p=109967"},"modified":"2024-06-24T10:36:10","modified_gmt":"2024-06-24T17:36:10","slug":"20240712-00","status":"publish","type":"post","link":"https:\/\/devblogs.microsoft.com\/oldnewthing\/20240712-00\/?p=109967","title":{"rendered":"Creating an already-completed asynchronous activity in C++\/WinRT, part 4"},"content":{"rendered":"

Last time, we created a generalized Make\u00adCompleted<\/code> for creating an already-completed asynchronous activity in C++\/WinRT<\/a>. Today, we’ll try to do the same for Make\u00adFailed<\/code>.<\/p>\n

In one sense, Make\u00adFailed<\/code> is easier because the body is the same regardless of which of the four types of asynchronous activities you’re making.<\/p>\n

winrt::Windows::Foundation::IAsyncAction\r\nMakeFailedAsyncAction(winrt::hresult_error error)\r\n{\r\n    (void) co_await winrt::get_cancellation_token();\r\n    throw error;\r\n}\r\n\r\ntemplate<typename Progress>\r\nwinrt::Windows::Foundation::IAsyncActionWithProgress<Progress>\r\nMakeFailedAsyncActionWithProgress(winrt::hresult_error error)\r\n{\r\n    (void) co_await winrt::get_cancellation_token();\r\n    throw error;\r\n}\r\n\r\ntemplate<typename Result, typename Progress>\r\nwinrt::Windows::Foundation::IAsyncOperation<Result>\r\nMakeFailedAsyncOperation(winrt::hresult_error error)\r\n{\r\n    (void) co_await winrt::get_cancellation_token();\r\n    throw error;\r\n}\r\n\r\ntemplate<typename Result, typename Progress>\r\nwinrt::Windows::Foundation::IAsyncOperationWithProgress<Result, Progress>\r\nMakeFailedAsyncOperationWithProgress(winrt::hresult_error error)\r\n{\r\n    (void) co_await winrt::get_cancellation_token();\r\n    throw error;\r\n}\r\n\r\n\/\/ Sample usage\r\nwinrt::Windows::Foundation::IAsyncOperation<int>\r\nGetSizeAsync()\r\n{\r\n    return MakeFailedAsyncOperation<int>(\r\n        winrt::hresult_not_implemented());\r\n}\r\n<\/pre>\n
This easily generalizes:<\/p>\n
template<typename Async>\r\nAsync MakeFailed(winrt::hresult_error error)\r\n{\r\n    (void) co_await winrt::get_cancellation_token();\r\n    throw error;\r\n}\r\n<\/pre>\n
Unfortunately, it’s also wrong.<\/p>\n
Since we receive the exception in the form of a hresult_error<\/code> by value, anybody who passes a derived exception like hresult_access_denied<\/code> will be subjected to  slicing<\/a>. You might think to avoid slicing by taking the parameter by reference, but that runs into two problems. First, you are carrying a reference across a co_await<\/code>, which may cause static analysis tools to get upset at you. Worse is that receiving the parameter as a reference doesn’t resolve the slicing because the throw<\/code> throws only the hresult_error<\/code> portion of the exception. Fortunately, this second problem is a non-issue in this specific case because it is captured and reported at the ABI to the coroutine consumer as an HRESULT<\/code> failure code from the GetResults()<\/code> method, and the consumer will realize that the HRESULT<\/code> is, say, E_INVALIDARG<\/code> and reconstruct a hresult_invalid_argument<\/code>.\u00b9<\/p>\n
The real problem is that  not all C++\/WinRT exceptions derive from hresult_error<\/code>. What if somebody wants to make a IAsyncAction<\/code> that failed with std::bad_alloc<\/code>?<\/p>\n
So we’ll accept anything that C++\/WinRT supports, which is anything derived from std::exception<\/code> or winrt::hresult_error<\/code>.<\/p>\n
template<typename Async, typename Error,\r\n    typename = std::enable_if_t<\r\n        std::is_base_of_v<std::exception, Error> ||\r\n        std::is_base_of_v<winrt::hresult_error, Error>>>\r\nAsync MakeFailed(Error error)\r\n{\r\n    (void) co_await winrt::get_cancellation_token();\r\n    throw error;\r\n}\r\n<\/pre>\n
When dealing with coroutines or exceptions (and especially in our case here, which is coroutines and<\/i> exceptions), you need to think about debuggability. Exceptions are nonlocal transfer, so it can be difficult to debug where an exception originated. And coroutines break up function execution into chunks, and most of the chunks run after the original call stack is lost, so that makes it even more frustrating. We’ll look into this next time.<\/p>\n
\u00b9 Related reading:  What happened to the custom exception description I threw from a C++\/WinRT IAsyncAction<\/code><\/a>?  How come my custom exception message is lost when it is thrown from a IAsyncAction<\/code>^<\/a>?<\/p>\n","protected":false},"excerpt":{"rendered":"
Failing is easy. Failing correctly is hard.<\/p>\n","protected":false},"author":1069,"featured_media":111744,"comment_status":"open","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"_acf_changed":false,"footnotes":""},"categories":[1],"tags":[25],"class_list":["post-109967","post","type-post","status-publish","format-standard","has-post-thumbnail","hentry","category-oldnewthing","tag-code"],"acf":[],"blog_post_summary":"
Failing is easy. Failing correctly is hard.<\/p>\n","_links":{"self":[{"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/posts\/109967","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/users\/1069"}],"replies":[{"embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/comments?post=109967"}],"version-history":[{"count":0,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/posts\/109967\/revisions"}],"wp:featuredmedia":[{"embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/media\/111744"}],"wp:attachment":[{"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/media?parent=109967"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/categories?post=109967"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/tags?post=109967"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}