{"id":100035,"date":"2018-10-23T07:00:00","date_gmt":"2018-10-23T21:00:00","guid":{"rendered":"https:\/\/blogs.msdn.microsoft.com\/oldnewthing\/?p=100035"},"modified":"2019-03-13T00:22:28","modified_gmt":"2019-03-13T07:22:28","slug":"20181023-00","status":"publish","type":"post","link":"https:\/\/devblogs.microsoft.com\/oldnewthing\/20181023-00\/?p=100035","title":{"rendered":"Adding a Ctrl+arrow accelerator for moving the trackbar by just one unit, part 1: Initial plunge"},"content":{"rendered":"

When you create a trackbar common control<\/a>, you can specify how far the arrow keys will change the trackbar position (default: 1 unit) and how far the PgUp<\/kbd> and PgDn<\/kbd> keys will change the trackbar position (default: one fifth of the range). <\/p>\n

If you change the default distance for the arrow keys to, say, five units, then you probably want to add a keyboard accelerator for moving by just one units, so that somebody can use PgUp<\/code> and PgDn<\/code> to get in the general area they want to be, then the arrow keys to get close, and then finally the Ctrl<\/kbd>+arrow keys to get the exact value. <\/p>\n

Take the scratch program<\/a> and make the following changes: <\/p>\n

\n#include <strsafe.h><\/font>\n\nBOOL\nOnCreate(HWND hwnd, LPCREATESTRUCT lpcs)\n{\n g_hwndChild = CreateWindow(TRACKBAR_CLASS, TEXT(\"\"),\n    WS_CHILD | WS_VISIBLE,\n    0, 0, 100, 100,\n    hwnd, (HMENU)100, g_hinst, 0);\n\n  SendMessage(g_hwndChild, TBM_SETLINESIZE, 0, 5);\n  SendMessage(g_hwndChild, TBM_SETPAGESIZE, 0, 20);<\/font>\n\n  return TRUE;\n}\n<\/pre>\n
We start by creating a trackbar control and setting the line size to 5 units and page size to 20 units. <\/p>\n
\nvoid OnHScroll(HWND hwnd, HWND hwndCtl, UINT code, int pos)\n{\n if (hwndCtl == g_hwndChild) {\n  TCHAR buf[128];\n  pos = (int)SendMessage(hwndCtl, TBM_GETPOS, 0, 0);\n  StringCchPrintf(buf, ARRAYSIZE(buf), TEXT(\"pos = %d\"), pos);\n  SetWindowText(hwnd, buf);\n }\n}\n\n    HANDLE_MSG(hwnd, WM_HSCROLL, OnHScroll);<\/font>\n<\/pre>\n
And we respond to the WM_<\/code>HSCROLL<\/code> message by displaying the trackbar’s new position. <\/p>\n
If you run this program, you’ll see a happy trackbar, and you can use the keyboard to move the thumb by 20 units (with PgUp<\/code> and PgDn<\/code>), or by 5 units (with the left and right arrow keys). But there’s no way to move the thumb by just one unit. <\/p>\n
Let’s fix that. <\/p>\n
But how? <\/p>\n
The first thing that comes to mind is to subclass the trackbar control and add a new keyboard accelerator. So let’s do that. <\/p>\n
\nLRESULT CALLBACK TrackbarKeyProc(\n    HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam,\n    UINT_PTR uIdSubclass, DWORD_PTR dwRefData)\n{\n if (uMsg == WM_KEYDOWN && GetKeyState(VK_CONTROL) < 0) {\n  int delta = 0;\n  if (wParam == VK_LEFT) {\n   delta = -1;\n  } else if (wParam == VK_RIGHT) {\n   delta = +1;\n  }\n\n  if (delta) {\n   auto pos = SendMessage(hwnd, TBM_GETPOS, 0, 0);\n   pos += delta;\n   SendMessage(hwnd, TBM_SETPOS, TRUE, pos);\n   FORWARD_WM_HSCROLL(GetParent(hwnd), hwnd,\n    delta < 0 ? TB_LINEUP : TB_LINEDOWN, 0, SendMessage);\n   return 0;\n  }\n }\n return DefSubclassProc(hwnd, uMsg, wParam, lParam);\n}<\/font>\n\nBOOL\nOnCreate(HWND hwnd, LPCREATESTRUCT lpcs)\n{\n g_hwndChild = CreateWindow(TRACKBAR_CLASS, TEXT(\"\"),\n    WS_CHILD | WS_VISIBLE, 0, 0, 100, 100,\n    hwnd, (HMENU)100, g_hinst, 0);\n\n  SendMessage(g_hwndChild, TBM_SETLINESIZE, 0, 5);\n  SendMessage(g_hwndChild, TBM_SETPAGESIZE, 0, 20);\n\n  SetWindowSubclass(g_hwndChild, TrackbarKeyProc, 0, 0);<\/font>\n  return TRUE;\n}\n\nvoid\nOnDestroy(HWND hwnd)\n{\n  RemoveWindowSubclass(g_hwndChild, TrackbarKeyProc, 0);<\/font>\n  PostQuitMessage(0);\n}\n<\/pre>\n
With this version, you can hold the Ctrl<\/kbd> key when pressing the left or right arrow keys, and the position will change by just one unit. <\/p>\n
Mission accomplished? <\/p>\n
Not quite. There’s still a lot of stuff missing. You may not notice it right away, but you will eventually, probably when one of your customers reports a problem that makes you have to scramble a fix. <\/p>\n
For example, this code doesn’t manage keyboard focus indicators. Let’s fix that. <\/p>\n
\nLRESULT CALLBACK TrackbarKeyProc(\n    HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam,\n    UINT_PTR uIdSubclass, DWORD_PTR dwRefData)\n{\n if (uMsg == WM_KEYDOWN && GetKeyState(VK_CONTROL) < 0) {\n  ...\n  if (delta) {\n   ...\n   FORWARD_WM_HSCROLL(GetParent(hwnd), hwnd,\n    delta < 0 ? TB_LINEUP : TB_LINEDOWN, 0, SendMessage);\n   SendMessage(hwnd, WM_CHANGEUISTATE,\n    MAKELONG(UIS_CLEAR, UISF_HIDEFOCUS), 0);<\/font>\n   return 0;\n  }\n }\n return DefSubclassProc(hwnd, uMsg, wParam, lParam);\n}\n<\/pre>\n
Next, this version doesn’t support vertical trackbars at all. If you add the TBS_<\/code>VERT<\/code> style to the Create­Window<\/code> call, you’ll have a vertical scroll bar, and we haven’t been doing anything with the up and down arrows. <\/p>\n
In related news, the trackbar allows you to use the up and down arrows to change the position of horizontal scroll bars. The up arrow behaves like the right arrow, and the down arrow behaves like the left arrow. Maybe you have customers who rely on this behavior, say, because that’s what their accessibility tool uses. <\/p>\n
Fortunately, one set of changes covers both of these issues. <\/p>\n
\nLRESULT CALLBACK TrackbarKeyProc(\n    HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam,\n    UINT_PTR uIdSubclass, DWORD_PTR dwRefData)\n{\n if (uMsg == WM_KEYDOWN && GetKeyState(VK_CONTROL) < 0) {\n  int delta = 0;\n  if (wParam == VK_LEFT || wParam == VK_UP<\/font>) {\n   delta = -1;\n  } else if (wParam == VK_RIGHT || wParam == VK_DOWN<\/font>) {\n   delta = +1;\n  }\n  ...\n }\n return DefSubclassProc(hwnd, uMsg, wParam, lParam);\n}\n<\/pre>\n
But wait, there’s also the TBS_<\/code>DOWN­IS­LEFT<\/code> style that changes the mapping between vertical and horizontal. If the style is set, then the up arrow acts like the left arrow, and the down arrow acts like the right arrow. <\/p>\n
Okay, so let’s fix that too. <\/p>\n
\nWPARAM SwapKeys(WPARAM wParam, UINT vk1, UINT vk2)\n{\n  if (wParam == vk1) return vk2;\n  if (wParam == vk2) return vk1;\n  return wParam;\n}<\/font>\n\nLRESULT CALLBACK TrackbarKeyProc(\n    HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam,\n    UINT_PTR uIdSubclass, DWORD_PTR dwRefData)\n{\n if (uMsg == WM_KEYDOWN && GetKeyState(VK_CONTROL) < 0) {\n  DWORD style = GetWindowStyle(hwnd);\n  if (style & TBS_DOWNISLEFT) {\n   if (style & TBS_VERT) {\n    wParam = SwapKeys(wParam, VK_LEFT, VK_RIGHT);\n   } else {\n    wParam = SwapKeys(wParam, VK_UP, VK_DOWN);\n   }\n  }<\/font>\n\n  int delta = 0;\n  if (wParam == VK_LEFT || wParam == VK_UP) {\n   delta = -1;\n  } else if (wParam == VK_RIGHT || wParam == VK_DOWN) {\n   delta = +1;\n  }\n\n  if (delta) {\n   auto pos = SendMessage(hwnd, TBM_GETPOS, 0, 0);\n   pos += delta;\n   SendMessage(hwnd, TBM_SETPOS, TRUE, pos);\n   FORWARD_WM_HSCROLL(GetParent(hwnd), hwnd,\n    delta < 0 ? TB_LINEUP : TB_LINEDOWN, 0, SendMessage);\n   SendMessage(hwnd, WM_CHANGEUISTATE,\n    MAKELONG(UIS_CLEAR, UISF_HIDEFOCUS), 0);\n   return 0;\n  }\n }\n return DefSubclassProc(hwnd, uMsg, wParam, lParam);\n}\n<\/pre>\n
Okay, are we done now? <\/p>\n
Nope, you still have right-to-left languages to deal with. In those cases, we want to flip the meanings of the left and right arrows. <\/p>\n
\nLRESULT CALLBACK TrackbarKeyProc(\n    HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam,\n    UINT_PTR uIdSubclass, DWORD_PTR dwRefData)\n{\n if (uMsg == WM_KEYDOWN && GetKeyState(VK_CONTROL) < 0) {\n  if (GetWindowExStyle(hwnd) & WS_EX_LAYOUTRTL) {\n   wParam = SwapKeys(wParam, VK_LEFT, VK_RIGHT);\n  }<\/font>\n\n  DWORD style = GetWindowStyle(hwnd);\n  if (style & TBS_DOWNISLEFT) {\n   if (style & TBS_VERT) {\n    wParam = SwapKeys(wParam, VK_LEFT, VK_RIGHT);\n   } else {\n    wParam = SwapKeys(wParam, VK_UP, VK_DOWN);\n   }\n  }\n\n  int delta = 0;\n  if (wParam == VK_LEFT || wParam == VK_UP) {\n   delta = -1;\n  } else if (wParam == VK_RIGHT || wParam == VK_DOWN) {\n   delta = +1;\n  }\n\n  if (delta) {\n   auto pos = SendMessage(hwnd, TBM_GETPOS, 0, 0);\n   pos += delta;\n   SendMessage(hwnd, TBM_SETPOS, TRUE, pos);\n   FORWARD_WM_HSCROLL(GetParent(hwnd), hwnd,\n    delta < 0 ? TB_LINEUP : TB_LINEDOWN, 0, SendMessage);\n   SendMessage(hwnd, WM_CHANGEUISTATE,\n    MAKELONG(UIS_CLEAR, UISF_HIDEFOCUS), 0);\n   return 0;\n  }\n }\n return DefSubclassProc(hwnd, uMsg, wParam, lParam);\n}\n<\/pre>\n
Okay, now<\/i> are we done? <\/p>\n
Maybe. I think that covers the remaining issues, but maybe I missed something. <\/p>\n
Y’know, this started out as a simple fix, but all the special cases turned it into a complicated mess. And maybe a future version of the trackbar control will add yet another style that introduces another special case. What we really want to do is hook into the control after it has decided what to do with the keyboard and before it changes the trackbar position. <\/p>\n
Let’s work on that next time. <\/p>\n","protected":false},"excerpt":{"rendered":"
The obvious thing starts to get out of hand.<\/p>\n","protected":false},"author":1069,"featured_media":111744,"comment_status":"open","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"_acf_changed":false,"footnotes":""},"categories":[1],"tags":[25],"class_list":["post-100035","post","type-post","status-publish","format-standard","has-post-thumbnail","hentry","category-oldnewthing","tag-code"],"acf":[],"blog_post_summary":"
The obvious thing starts to get out of hand.<\/p>\n","_links":{"self":[{"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/posts\/100035","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/users\/1069"}],"replies":[{"embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/comments?post=100035"}],"version-history":[{"count":0,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/posts\/100035\/revisions"}],"wp:featuredmedia":[{"embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/media\/111744"}],"wp:attachment":[{"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/media?parent=100035"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/categories?post=100035"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/devblogs.microsoft.com\/oldnewthing\/wp-json\/wp\/v2\/tags?post=100035"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}